fix(op-batcher): solve race condition of BatchSubmitter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and handleReceipt access state concurrently
bnoieh
referenced
this pull request
in bnoieh/opbnb
Jul 14, 2023
owen-reorg
added a commit
that referenced
this pull request
Sep 26, 2023
* op-batcher: Add metrics for pending L2 transaction data size (#5797) * feat(op-node): Finalize Mainnet Rollup Config [release branch] (#5905) * copy over develop chainsgo * stage rollup config changes * final rollup config values * fix(op-batcher): solve race condition of BatchSubmitter publishTxToL1 and handleReceipt access state concurrently (#5) * chore: update readme, add testnet assets (#9) * chore: update readme, add testnet assets * doc: clarify readme * ci: add the ci code used to package and release docker images (#11) * ci: add the ci code used to package and release docker images (#7) * ci: add the ci code used to package and release docker images Co-authored-by: Welkin <welkin.b@nodereal.com> * fix: add latest tag for docker image (#9) Co-authored-by: Welkin <welkin.b@nodereal.com> * try to use cache for docker build (#10) Co-authored-by: Welkin <welkin.b@nodereal.com> --------- Co-authored-by: Welkin <welkin.b@nodereal.com> * feat(ci): add ci workflow * fix * fix * update * update * skip fail test temporarily * add batcher/proposer * add e2e * skip fail e2e case temporary * add op-node-lint * fix lint * add batcher/proposer lint * test junit-report * add junit report for all * adjust parallel to 2 for avoiding fail * add needs for job serial execution * use testname format to simplify result --------- Co-authored-by: Joshua Gutow <jgutow@oplabs.co> Co-authored-by: refcell.eth <abigger87@gmail.com> Co-authored-by: bnoieh <135800952+bnoieh@users.noreply.github.com> Co-authored-by: Owen <owen.h@nodereal.io> Co-authored-by: Welkin <welkin.b@nodereal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BatchSubmitter.publishTxToL1 and BatchSubmitter.handleReceipt access state concurrently, which will cause op-batcher panic: