executor: fix full exit nft #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Oct 11, 2022
| return nil | ||
| } | ||
|
|
||
| func (e *FullExitNftExecutor) VerifyInputs(skipGasAmtChk bool) error { | ||
| bc := e.bc |
There was a problem hiding this comment.
Is this because FullExitNft should always be executed? If that is the case, can you take some time to check other executor that does unnecessary verify, and fix it in another new PR.
unclezoro
approved these changes
Oct 11, 2022
yutianwu
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix full exit nft executor.
Rationale
There are two cases we should exit an empty nft:
Both these two cases we should handle correctly, but the earlier logic isn't correct, so fix it.
Example
NA
Changes
Notable changes:
Note
/update-integration-keyfile