Jenkins.Init() should check Response.StatusCode

[Bpazy]

Jenkins.Init() return success even if invoking gojenkins.CraeteJenkins with wrong auth.

Here is the example code:

jenkins, err := gojenkins.CreateJenkins(nil, "http://somejenkins.org/", "username", "some wrong token").Init()
if err != nil {
        // Never invoked but shoud be.
	fmt.Printf("%+v", err)
	return
}

So Jenkins.Init() should check Response.StatusCode:

gojenkins/jenkins.go

Lines 51 to 67 in 65ee8c9

	func (j *Jenkins) Init() (*Jenkins, error) {
	j.initLoggers()
	// Check Connection
	j.Raw = new(ExecutorResponse)
	rsp, err := j.Requester.GetJSON("/", j.Raw, nil)
	if err != nil {
	return nil, err
	}
	j.Version = rsp.Header.Get("X-Jenkins")
	if j.Raw == nil {
	return nil, errors.New("Connection Failed, Please verify that the host and credentials are correct.")
	}
	return j, nil
	}

The code should be written like this:

func (j *Jenkins) Init() (*Jenkins, error) {
	j.initLoggers()

	// Check Connection
	j.Raw = new(ExecutorResponse)
	rsp, err := j.Requester.GetJSON("/", j.Raw, nil)
	if err != nil {
		return nil, err
	}

	j.Version = rsp.Header.Get("X-Jenkins")
	if j.Raw == nil || rsp.StatusCode != http.StatusOK { // Check rsp.StatusCode
		return nil, errors.New("Connection Failed, Please verify that the host and credentials are correct.")
	}

	return j, nil
}

Jenkins version: 2.176.1

[eryajf]

I have the same problem

[Bpazy]

@eryajf Maybe you can try my fork: https://github.com/Bpazy/gojenkins

PR: #214

[figo]

#214 merged, try the latest code please @eryajf

[eryajf]

#214 merged, try the latest code please @eryajf

Thank you, it has been successful, but I have used it locally, I hope the official package can have more methods for folder operations

[vperson]

I think you should put the status code of the request in the error message
For example like this

	j.Version = rsp.Header.Get("X-Jenkins")
	if j.Raw == nil || rsp.StatusCode != http.StatusOK {
		return nil, errors.New(fmt.Sprintf("Connection Failed, Please verify that the host and credentials are correct, Status Code %d", rsp.StatusCode))
	}