fix: gojenkins.Task.GetJob return 404 for subtask #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
figo
requested changes
Jan 9, 2024
go.mod
Outdated
| @@ -1,4 +1,4 @@ | |||
| module github.com/bndr/gojenkins | |||
| module github.com/caiyili/gojenkins | |||
There was a problem hiding this comment.
Please don't change the module path, thanks
There was a problem hiding this comment.
Thank you for catching that - you're right, I should not have changed the module path. I've reverted the change and updated the path back to the original. Please take a look and let me know if this works for you now. Appreciate the feedback to improve my work.
|
i face this issue too, why this still not be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this job is a subtask, such as JENKINS_URL/job/$folder/job/$job-name, the Task.GetJob function will return a 404 error as it did not pass the parentIDs parameter when calling Jenkins.GetJob.