Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dummy pr to test new ci #273

Closed
wants to merge 1 commit into from
Closed

dummy pr to test new ci #273

wants to merge 1 commit into from

Conversation

alan-barzilay
Copy link
Collaborator

No description provided.

@@ -333,7 +333,7 @@ def compare_modules(file_, imports):

Args:
file_ (str): File to parse for modules to be compared.
imports (tuple): Modules being imported in the project.
imports (tuple): Modules being imported in the project.htrttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <501> reported by reviewdog 🐶
line too long (129 > 79 characters)

@@ -145,7 +145,7 @@ def test_init_savepath(self):
Test that we can save requirements.txt correctly
to a different path
"""
pipreqs.init({'<path>': self.project, '--savepath': self.alt_requirement_path,
pipreqs.init({'<path>': self.project, '--savepath': self.alt_requirement_path,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <501> reported by reviewdog 🐶
line too long (86 > 79 characters)

@@ -163,7 +163,7 @@ def test_init_overwrite(self):
"""
with open(self.requirements_path, "w") as f:
f.write("should_not_be_overwritten")
pipreqs.init({'<path>': self.project, '--savepath': None, '--use-local': None,
pipreqs.init({'<path>': self.project, '--savepath': None, '--use-local': None,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [flake8] <501> reported by reviewdog 🐶
line too long (86 > 79 characters)

@codecov-commenter
Copy link

Codecov Report

Merging #273 (bebf31a) into bye_travis (2b59751) will decrease coverage by 19.14%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           bye_travis     #273       +/-   ##
===============================================
- Coverage       87.50%   68.35%   -19.15%     
===============================================
  Files               2        2               
  Lines             256      256               
===============================================
- Hits              224      175       -49     
- Misses             32       81       +49     
Impacted Files Coverage Δ
pipreqs/pipreqs.py 67.98% <ø> (-19.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b59751...bebf31a. Read the comment docs.

@alan-barzilay
Copy link
Collaborator Author

seems to be working fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants