Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added group for org.osgi.annotation.bundle #22

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

scottslewis
Copy link
Contributor

@kriegfrj sorry I forgot the G in Gav coordinates.

Signed-off-by: Scott Lewis <scottslewis@gmail.com>
@kriegfrj kriegfrj merged commit dfda326 into bndtools:master Jun 7, 2023
2 checks passed
@kriegfrj
Copy link
Contributor

kriegfrj commented Jun 7, 2023

I'll try and read more carefully next time... (isn't it so often the way that the most trivial changes are the ones where we make the most mistakes? 😄)

@scottslewis
Copy link
Contributor Author

@kriegfrj I've discovered something: in current bnd/bndtools repo there is a file that contains the initialrepos. Here is it's current contents referring to this repo:

bndtools/workspace;branch=origin/${version;==;${base.version}},

This currently resolves to bndtools/workspace.branch=origin/7.0

And so the latest bndtools (master) still doesn't get the addition to master that was merged via this pr.

My question: When actually released will initialrepos.txt keep the same as above (7.0 branch of this repo) or will this be changed to master?

If it's going to stay at 7.0 then I expect that the merge done for master for this pr should be merged to 7.0 branch also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants