Skip to content
This repository has been archived by the owner on Nov 9, 2019. It is now read-only.

Fix password generation #13

Merged
merged 2 commits into from
Dec 9, 2015
Merged

Fix password generation #13

merged 2 commits into from
Dec 9, 2015

Conversation

leonklingele
Copy link
Collaborator

Old:

ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ

New:

0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~

This adds numbers (0-9) and removes duplicate chars (a-z, A-Z)

EDIT:
Additionally fixed the method as it was not working correctly.

@leonklingele
Fix characters used in generated passwords.
e18d622 
Old: ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ
New: 0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~
This adds numbers (0-9) and removes duplicate chars (a-z, A-Z)
@leonklingele leonklingele changed the title Fix characters used in generated passwords. Fix password generation Dec 7, 2015
@leonklingele
Copy link
Collaborator Author

Good catch. Will do a fix and git push -f.
For sure while can be removed. However this should not affect security of the system in any way.

bndw added a commit that referenced this pull request Dec 9, 2015
@bndw
Merge pull request #13 from leonklingele/fix-password-generation
a0094c1 
Fix password generation
@bndw bndw merged commit a0094c1 into bndw:master Dec 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonklingele @bndw