Skip to content
This repository has been archived by the owner on Nov 9, 2019. It is now read-only.

Move go to src folder, pre-commit hook #64

Merged
merged 3 commits into from
Sep 13, 2016

Conversation

leonklingele
Copy link
Collaborator

As discussed in #61, this PR

  • separates the Go code from the rest of the project by moving it to a src/ folder
  • adds a pre-commit hook to run tests and go fmt before a change can be commited

@leonklingele
Copy link
Collaborator Author

As soon as #48 is merged, I will also run go vet in the pre-commit hook.
This will greatly improve the code quality / standard conformity.

@leonklingele
Copy link
Collaborator Author

leonklingele commented Sep 10, 2016

On my machine, the pre-commit hook checks currently take about 3 seconds.
We need to find a way to cut this down.

@bndw
Copy link
Owner

bndw commented Sep 12, 2016

Once you rebase and this is merged, I've got a local branch that speeds up those tests.

@bndw
Copy link
Owner

bndw commented Sep 12, 2016

#66 Should make the pre-commit hook bearable.

@leonklingele
Copy link
Collaborator Author

Rebased.

@bndw
Copy link
Owner

bndw commented Sep 13, 2016

LGTM

EDIT
Moving forward, PRs should be opened against the develop branch #69

@bndw bndw merged commit 2786690 into bndw:master Sep 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants