Allow setting additional cards to print #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Looking forward to reviewing and giving this a try in the next couple of days. |
bndw
requested changes
Aug 13, 2023
bndw
approved these changes
Aug 15, 2023
|
Thanks for this @guicamest. It may take me some time to deploy this update to wificard.io, apologies in advance. |
|
No problem @bndw ! Happy to have contributed to this great open source project! I've already used it to print some locally; I guess docker users have it available too by now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269, #63, #31, #30.
There is now a setting to increase the amount of cards to be printed. The wifi-cards are displayed without any changes in size (i.e. it is NOT an amount of cards per page setting). Additionally, users can choose to hide the tip (or legend) to possibly fit more cards in one page. Some margins and rendering were changed to avoid unnecessary empty space in the final printing layout
Website now looks like this:
Attaching some previews with A4:
3 Landscape cards fit into portrait printed page
4 Landscape cards fit into landscape printed page
4 Landscape cards (without password nor legend) fit into portrait printed page
3 Rotated cards fit into landscape printed page
4 Rotated cards fit (without password) into portrait printed page
4 Rotated cards fit (without tip) into portrait printed page
4 Rotated cards fit into portrait printed page
6 Rotated cards fit (without password nor tip) into landscape printed page
6 Rotated cards fit (without password nor tip) into portrait printed page
