Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Fix focusing last line when using data-trim #18

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

toby-allsopp
Copy link
Contributor

The last line was not being wrapped in a when using data-trim because the
trailing newline was removed. Add a trailing newline.

The last line was not being wrapped in a <span> when using data-trim because the
trailing newline was removed. Add a trailing newline.
@bnjmnt4n bnjmnt4n merged commit db24baa into bnjmnt4n:master Nov 5, 2018
@bnjmnt4n
Copy link
Owner

bnjmnt4n commented Nov 5, 2018

Thanks for the PR!

bnjmnt4n pushed a commit that referenced this pull request Nov 5, 2018
The last line was not being wrapped in a `<span>` when using `data-trim`
because the trailing newline was removed.
bnjmnt4n added a commit that referenced this pull request Nov 5, 2018
@bnjmnt4n bnjmnt4n added the bug label Nov 5, 2018
@bnjmnt4n
Copy link
Owner

bnjmnt4n commented Nov 5, 2018

I've come to realise that previous behaviour was buggy: when parsing something like

<pre><code>// abc
// abc
</code></pre>

The third line was treated as non-existent, which does not follow the browsers' display of a third line.
I'll change the behavior to a more semantic one later.

Edit: Seems like I've misunderstood the behaviour, will take some time to review and update.

bnjmnt4n added a commit that referenced this pull request Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants