Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get/set as short method name in object #1072

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Fix get/set as short method name in object #1072

merged 1 commit into from
Jan 16, 2021

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Jan 14, 2021

Fix get andset so they can be used as short method name in object.

@tofpie tofpie added bug Something isn't working parser Issues surrounding the parser labels Jan 14, 2021
@tofpie tofpie added this to the v0.12.0 milestone Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1072 (85232b8) into master (aa03a7d) will decrease coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   58.69%   58.68%   -0.02%     
==========================================
  Files         176      176              
  Lines       12389    12395       +6     
==========================================
+ Hits         7272     7274       +2     
- Misses       5117     5121       +4     
Impacted Files Coverage Δ
...arser/expression/primary/object_initializer/mod.rs 65.65% <42.85%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa03a7d...85232b8. Read the comment docs.

@Razican
Copy link
Member

Razican commented Jan 15, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 24,795 24,801 +6
Ignored 15,587 15,587 0
Failed 38,115 38,109 -6
Panics 26 26 0
Conformance 31.59 31.59 +0.01%

@Razican Razican merged commit 1098b41 into boa-dev:master Jan 16, 2021
@tofpie tofpie deleted the fix-short-get-set branch January 18, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants