Add a boa_interop crate #3772
Add a boa_interop crate #3772
Conversation
This crate will contain types and functions to help integrating boa in Rust projects, making it easier to interop between the host and the JavaScript code. See boa-dev#3770
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3772 +/- ##
==========================================
+ Coverage 47.24% 49.71% +2.46%
==========================================
Files 476 456 -20
Lines 46892 44781 -2111
==========================================
+ Hits 22154 22261 +107
+ Misses 24738 22520 -2218 ☔ View full report in Codecov by Sentry. |
| impl HashMapModuleLoader { | ||
| /// Creates an empty `HashMapModuleLoader`. | ||
| #[must_use] | ||
| pub fn new() -> Self { |
There was a problem hiding this comment.
suggestion/issue: not sure that new is needed here if all it does is call Default
There was a problem hiding this comment.
Some people don't like to import default (it's not part of std prelude). I've seen this pattern in places, including the rust std: https://github.com/rust-lang/rust/blob/master/library/std/src/collections/hash/map.rs#L229-L234
I'm okay replacing it with empty() too if you want.
There was a problem hiding this comment.
I would say to just leave it. The std uses the same pattern of having a new method that does the same as default, so I think we should do the same.
| impl HashMapModuleLoader { | ||
| /// Creates an empty `HashMapModuleLoader`. | ||
| #[must_use] | ||
| pub fn new() -> Self { |
There was a problem hiding this comment.
I would say to just leave it. The std uses the same pattern of having a new method that does the same as default, so I think we should do the same.
This crate will contain types and functions to help integrating boa in Rust projects, making it easier to interop between the host and the JavaScript code.
See #3770