Replaced Pageobjects with more generalized option -M/--modules #55
Conversation
Switched Parameter -O or --pageobjects With Parameter -M/--module for clarity Changed Name of PageObjectAction to ModuleAction for Clarity and updated documentation Removed import from robotpageobjects and check for subclass Appended error message to "unable to import " message Added Test for new parameter help menu Updated old test to match new framework results Added "r" in SUITE_DIR Evaluate to fix issue with "\" causing bad path
|
Thanks, Charlie! Sorry it took so long to get it merged in. |
|
It's no problem Bryan. How yah been? |
|
Oh no! I mean, that's great! Unfortunately I'm going to be posting a page object library soon, too. I On Sun, Mar 27, 2016 at 10:39 AM, charleshamel73 notifications@github.com
|
|
Yeah. Well I'm interested in seeing how you coded yours. I remember all the issues with developing the library so I'm interested how you worked around them. |
Purpose:
I noticed that when using custom modules structure like pageobjects that the pageobject argument does not work. This change should work to remove the dependency on robotpageobjects while still allowing the ability for mass imports from a module. Also included is one new test for the parameter help menu and updated tests to match new framework changes.
Itemized Changes:
Added Import Error Message to the "unable to load library' message
Switched Parameter -O or --pageobjects With Parameter -M/--module for clarity
Changed Name of PageObjectAction to ModuleAction for Clarity and updated documentation
Removed import from robotpageobjects and check for subclass
Appended error message to "unable to import " message
Added Test for new parameter help menu
Updated old test to match new framework results
Added "r" in SUITE_DIR Evaluate to fix issue with "" causing bad path