forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log cleanup #24
Merged
Merged
Log cleanup #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: op-chain-ops/genesis/layer_one.go modified: op-chain-ops/state/state.go
Changes to be committed: modified: op-node/eth/account_proof.go modified: op-node/rollup/derive/attributes_queue.go modified: op-node/rollup/derive/batch_queue.go modified: op-node/rollup/derive/l1_traversal.go modified: op-node/sources/eth_client.go
Changes to be committed: modified: op-node/rollup/derive/pipeline.go modified: op-node/rollup/driver/state.go
Changes to be committed: modified: op-node/node/api.go
Changes to be committed: modified: boba-chain-ops/immutables/immutables.go
Changes to be committed: modified: op-node/rollup/driver/state.go
mmontour1306
force-pushed
the
mm/log-cleanup
branch
from
August 17, 2023 20:59
9efdfa1
to
6e93d74
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## boba-develop #24 +/- ##
================================================
+ Coverage 45.20% 45.28% +0.07%
================================================
Files 439 439
Lines 30132 30121 -11
Branches 1975 1975
================================================
+ Hits 13620 13639 +19
+ Misses 15039 15014 -25
+ Partials 1473 1468 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
boyuan-chen
approved these changes
Aug 18, 2023
InoMurko
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've closed my previous PR and opened this one covering only the log cleanup, not touching the bindings. I'll deal with those on a different branch.