Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log cleanup #24

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Log cleanup #24

merged 6 commits into from
Aug 23, 2023

Conversation

mmontour1306
Copy link

I've closed my previous PR and opened this one covering only the log cleanup, not touching the bindings. I'll deal with those on a different branch.

 Changes to be committed:
	modified:   op-chain-ops/genesis/layer_one.go
	modified:   op-chain-ops/state/state.go
 Changes to be committed:
	modified:   op-node/eth/account_proof.go
	modified:   op-node/rollup/derive/attributes_queue.go
	modified:   op-node/rollup/derive/batch_queue.go
	modified:   op-node/rollup/derive/l1_traversal.go
	modified:   op-node/sources/eth_client.go
 Changes to be committed:
	modified:   op-node/rollup/derive/pipeline.go
	modified:   op-node/rollup/driver/state.go
 Changes to be committed:
	modified:   op-node/node/api.go
 Changes to be committed:
	modified:   boba-chain-ops/immutables/immutables.go
 Changes to be committed:
	modified:   op-node/rollup/driver/state.go
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #24 (6e93d74) into boba-develop (336d4ed) will increase coverage by 0.07%.
The diff coverage is 62.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           boba-develop      #24      +/-   ##
================================================
+ Coverage         45.20%   45.28%   +0.07%     
================================================
  Files               439      439              
  Lines             30132    30121      -11     
  Branches           1975     1975              
================================================
+ Hits              13620    13639      +19     
+ Misses            15039    15014      -25     
+ Partials           1473     1468       -5     
Flag Coverage Δ
bedrock-go-tests 50.22% <62.50%> (+0.10%) ⬆️
cannon-go-tests 81.74% <ø> (ø)
chain-mon-tests 26.95% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 41.54% <ø> (+0.07%) ⬆️
contracts-ts-tests 6.88% <ø> (ø)
core-utils-tests 44.24% <ø> (ø)
sdk-next-tests 42.60% <ø> (ø)
sdk-tests 42.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
op-chain-ops/state/state.go 63.23% <ø> (-0.54%) ⬇️
op-node/rollup/derive/attributes_queue.go 38.29% <ø> (+0.79%) ⬆️
op-node/rollup/derive/batch_queue.go 72.67% <ø> (-0.16%) ⬇️
op-node/rollup/derive/l1_traversal.go 76.08% <ø> (-0.51%) ⬇️
op-node/rollup/derive/pipeline.go 0.00% <ø> (ø)
op-node/rollup/driver/state.go 0.00% <ø> (ø)
op-node/sources/eth_client.go 40.25% <0.00%> (ø)
op-chain-ops/genesis/layer_one.go 74.17% <50.00%> (ø)
op-node/eth/account_proof.go 60.78% <100.00%> (-2.18%) ⬇️
op-node/node/api.go 42.16% <100.00%> (ø)

... and 5 files with indirect coverage changes

@mmontour1306 mmontour1306 merged commit 9798ad4 into boba-develop Aug 23, 2023
1 check passed
@mmontour1306 mmontour1306 deleted the mm/log-cleanup branch August 23, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants