Remove dangling urfavcli v1 reference #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream has moved onto urfavcli v2, but we are holding onto an old file because we have not migrated yet, that still references v1. This isn't the end of the world, but it creates an unnecessary diff in our go.mod files. Since v2 is _mostly_ compatible with v1, simply changing the import is sufficient to migrate in this case.
mmontour1306
approved these changes
Oct 10, 2023
boyuan-chen
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream has moved onto urfavcli v2, but we are holding onto an old file because we have not migrated yet, that still references v1. This isn't the end of the world, but it creates an unnecessary diff in our go.mod files. Since v2 is mostly compatible with v1, simply changing the import is sufficient to migrate in this case.