Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC timeout for op-node #77

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Add RPC timeout for op-node #77

merged 5 commits into from
Oct 31, 2023

Conversation

boyuan-chen
Copy link

This RPCTimeout flag is used to set the timeout for the eth_getProof request, so we can let op-node wait for the response longer and op-proposer can get the result from the op-node.

Copy link

@InoMurko InoMurko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push it upstream too

Copy link

@jyellick jyellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long exactly is the call taking? If this is problematic for a devnet, do we know how this will scale for a mainnet? Any useful parameters (like size of the state tree, number of historical blocks, etc.)

@boyuan-chen
Copy link
Author

How long exactly is the call taking? If this is problematic for a devnet, do we know how this will scale for a mainnet? Any useful parameters (like size of the state tree, number of historical blocks, etc.)

It takes about 45 seconds to obtain the proof for the block that is 1,485,736 blocks behind the header.

@boyuan-chen
Copy link
Author

I will merge this PR first, then will create an upstream PR

@boyuan-chen boyuan-chen merged commit 88e331b into develop Oct 31, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants