Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add partial withdraw to contract #30

Merged
merged 6 commits into from
Apr 29, 2024
Merged

feat: Add partial withdraw to contract #30

merged 6 commits into from
Apr 29, 2024

Conversation

wsdt
Copy link
Contributor

@wsdt wsdt commented Apr 22, 2024

No description provided.

souradeep-das
souradeep-das approved these changes Apr 25, 2024
View reviewed changes
contracts/LightBridge.sol Show resolved Hide resolved
souhaillM
souhaillM approved these changes Apr 25, 2024
View reviewed changes
Copy link

@souhaillM souhaillM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the change was adding the _amount variable, We can also avoid duplication by emitting the AssetBalanceWithdrawn one time at the end of the function.

@wsdt wsdt merged commit 6ae98fd into main Apr 29, 2024
1 check passed
@wsdt wsdt deleted the wsdt/withdraw-partially branch April 29, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souhaillM souhaillM souhaillM approved these changes

@boyuan-chen boyuan-chen boyuan-chen approved these changes

@souradeep-das souradeep-das souradeep-das approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wsdt @souradeep-das @boyuan-chen @souhaillM