Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination not working in WordPress 4.4 #13

Closed
bobbingwide opened this issue Dec 20, 2015 · 2 comments
Closed

Pagination not working in WordPress 4.4 #13

bobbingwide opened this issue Dec 20, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@bobbingwide
Copy link
Owner

It took me a while to notice, but after upgrading to WordPress 4.4, we realised that pagination was not working properly. The x to y of z information and the paging links were correct, but the listed content being displayed was always from page one.

Explanation

The function _bw_get_posts() which is used when we need the total number of posts was passing the default value for offset, 0. It seems that this should now be ''.

Temporary fix

Change the code in _bw_get_posts() from 'offset' => 0 to 'offset' => ''
File oik/includes/bw_posts.inc
This fix has been applied to oik-plugins.com

Permanent fix

Publish a new version of the oik base plugin. Rather than issue v2.5.1 we may decide to officially release version v3.0.0.

@bobbingwide
Copy link
Owner Author

The problem came about due to a change in WordPress 4.4 for TRAC 34060. I have raised TRAC 35172 since this change broke backward compatibility.

bobbingwide added a commit that referenced this issue Dec 20, 2015
The fix for Issue #13 will also be applied to a 2.5.1 branch on wordpress.org
@bobbingwide bobbingwide added this to the oik v3.0.0 milestone Dec 20, 2015
@bobbingwide bobbingwide self-assigned this Dec 20, 2015
@bobbingwide
Copy link
Owner Author

In order to deliver 2.5.1 we need to make oik compatible with oik-bwtrace v2.0.9 and oik-lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant