Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove block override dependency on Gutenberg #34

Open
bobbingwide opened this issue May 12, 2022 · 0 comments
Open

Remove block override dependency on Gutenberg #34

bobbingwide opened this issue May 12, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

There are currently major performance problems attempting to use the Site Editor to edit the SB theme. See #6.

In order to determine what's causing these problems I want to be able to test the theme in multiple environments, with fewer activated plugins.

Requirement

The block override logic should work even when Gutenberg is not activated.

Proposed solution

I implemented this for Fizzie. Similar code will be needed in the block overrides for SB.

  1. The sb_maybe_override_block() function needed check the currently assigned render_callback function
  2. Each block override function that references a gutenberg_ prefixed function should test for its existence before calling it.
@bobbingwide bobbingwide added the enhancement New feature or request label May 12, 2022
@bobbingwide bobbingwide self-assigned this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant