Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems creating footer template part with Tag cloud and colours #5

Closed
bobbingwide opened this issue Mar 23, 2021 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@bobbingwide
Copy link
Owner

In the Site Editor this first pass at the footer area seems reasonable.
image

But these are a number of problems.
This is what I see in the front end.
image

Problems

  1. Front end - Tag cloud in the front end is displayed with <br /> between each link - when formatted in a column.
  2. Editor -Tag cloud colour cannot be set
  3. Front end - White colour for the headings has not been respected
  4. Editor - Accidentally clicking on a tag cloud link leaves the Site Editor - changes not saved.
  5. Editor - Tag clouds only work for certain taxonomies
  6. Front end - Group block - no matter what I do it's always full width.
@bobbingwide
Copy link
Owner Author

bobbingwide commented Mar 24, 2021

Front end - Tag cloud in the front end is displayed with <br /> between each link - when formatted in a template part.

As expected, this is another instance of the problem I raised with wpautop() being run for template parts.
WordPress/gutenberg#26731

Commenting out line 104 of build/block-library/blocks/template-part.php resolves the problem.

//$content = wpautop( $content );

The fix needs to be applied to packages/block-library/src/template-part/index.php.
image

I can apply the same workaround as I did for Fizzie; override the rendering of template parts.

@bobbingwide
Copy link
Owner Author

Editor -Tag cloud colour cannot be set

Two things here.

  1. The tag cloud doesn't support colours
  2. I only need to change the colour of links in a footer

@bobbingwide
Copy link
Owner Author

bobbingwide commented Mar 24, 2021

  1. Front end - White colour for the headings has not been respected

This appears to be the same problem as WordPress/gutenberg#29535
But I got a different result from Carolina's comment WordPress/gutenberg#29535 (comment)

I've worked around the problem by removing the unnecessary colour for link, which added the style attribute which didn't look quite right to me.

style="--wp--style--color--link:var(--wp--preset--color--background)"

Elsewhere the inline CSS sets the color property as:

color:var(--wp--style--color--link,#00e)

bobbingwide added a commit that referenced this issue Mar 24, 2021
@bobbingwide bobbingwide self-assigned this Mar 24, 2021
@bobbingwide bobbingwide added the bug Something isn't working label Mar 24, 2021
bobbingwide added a commit that referenced this issue Mar 26, 2021
… parts. Issue #7: cater for unregistered taxonomies
@bobbingwide
Copy link
Owner Author

Whereas the Tag cloud is working fine in the footer, the archive pages for s-word and b-word haven't yet been developed.
Leaving open therefore.

@bobbingwide
Copy link
Owner Author

the archive pages for s-word and b-word haven't yet been developed. Leaving open therefore.

I didn't need to develop archive pages for taxonomies - index.html does the job.

The template part override, commenting out wpautop(), is still in place.
So is the, possibly unnecessary, tag cloud override.

Closing anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant