Bugfix/missing route param in request #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2019 11:21
…emBundle into bugfix/missing_route_param_in_request
|
Hey @WhiteRabbitDE , Sorry for the delay! Your changes make sense... and yeah, I don't think it will cause any problems with BC break. Thank you for this fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in the isActiveFilter and isActiveFunction.
Until now, the request used to compare was created with createFromGlobal. This request did not contain the request parameters in $this->request->attributes->parameters e.g. "_route" which is used for comparison in the is_active filter.
The request stack is available since symfony 2.4 so i think this shouldnt be a BC. right @bocharsky-bw ?