Version 1.0.0 #27
Merged
Version 1.0.0 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the forked DNS client * Rename dh.DH -> dh.Client and gss.GSS -> gss.Client as there can in theory be a server version * Rename dh.New -> dh.NewClient and gss.New -> gss.NewClient which now takes a *dns.Client which is used for the TKEY negotiation * Change dh.Client.NegotiateKey to return literal values instead of pointers * Change dh.Client.DeleteKey to require a literal string * Rename gss.Client.GenerateGSS and gss.Client.VerifyGSS to gss.Client.Generate and gss.Client.Verify respectively and update the signatures to just be passed []byte and *dns.TSIG * Change gss.Client.NegotiateContext* to return literal values instead of pointers * Change gss.Client.DeleteContext to require a literal string * Change tsig.ExchangeTKEY to require a dns.Client and literal strings * Add tsig.CopyDNSClient which returns a copy of a dns.Client with the network changed to TCP, respecting any IPv4 or IPv6 choice fixes #15
Drop tsig.SplitHostPort and use net.SplitHostPort instead.
Make util.ExchangeTKEY not require the optional TSIG MAC but require the passed dns.Client to be configured beforehand.
This is needed because Windows signs the TKEY response with a TSIG record using the same TKEY which creates a chicken & egg problem.
Makes it easier to test later.
This version has the necessary dns.TsigProvider interface.
Builds and spins up Kerberos and BIND containers in Docker and exports a keytab for tests.
This was
linked to
issues
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the upstream DNS library has accepted a revised PR, this library can be finalised.