Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shabads search is not complete was searching for ik til nahi visrey and it showed nothing #19

Closed
ravjot28 opened this issue Dec 17, 2015 · 4 comments
Labels
Milestone

Comments

@ravjot28
Copy link
Collaborator

No description provided.

@bogas04
Copy link
Owner

bogas04 commented Dec 17, 2015

It is from amrit kirtan's index.
Challenges are:

  • different spellings for same words make it hard to search
  • you don't always remember the rahao pangti, which is what the index is based on

I'm still looking for some good database that can help in searching and indexing.

@bogas04 bogas04 added the bug label Oct 15, 2016
@bogas04
Copy link
Owner

bogas04 commented Oct 18, 2016

I'll try to use iGurbaniDB.

@bogas04
Copy link
Owner

bogas04 commented Oct 23, 2016

Thanks to GurbaniNow, I am able to create a decent Shabad Searcher. Will release it tonight hopefully to the master branch.

To improve performance however I guess we can cache all the Shabads (1-12,817, once his DB is finalised) to our docs/json/hymn/ folder. This will also assist Service Worker.

@bogas04
Copy link
Owner

bogas04 commented Oct 23, 2016

Once we have the hymns, then we can simply ask users/devs to create PRs to the above hymns to put meta content like

{
  "ShabadID": 1234,
  "...": { ... },
  "Kirtans": [
      "https://soundcloud.com/...",
      "https://youtube.com/....",
      "..."
   ]},
   "Kathas": [
     { "By": "Basics of Sikhi", "src": "https://youtube.com..." },
     { "By": "Bhai Sukha Singh UK", "src": "https://youtube.com..." }
   ]},
   "Misc": [
     "https://wikipedia....",
     "https://sikhwiki...",
     "https://reddit.com/r/sikh/..."
   ]},
}

I love this idea personally as it makes use of Open Source ! Maybe a UI can be created that helps user create such PR. Let's have discuss over this over #21

bogas04 added a commit that referenced this issue Oct 23, 2016
@bogas04 bogas04 closed this as completed Oct 23, 2016
@bogas04 bogas04 mentioned this issue Oct 23, 2016
4 tasks
@bogas04 bogas04 added this to the v0.5.0 milestone Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants