Return false from checkIfCacheExists when error is 403 #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #433
When GetHeadObject command is returned if you don't have
s3:ListBucket
permissions, then you will receive a 403 error. This case would still indicate that the bucket object exists.See: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/s3/command/HeadObjectCommand/
The same solution exists in the
nx-remotecache-s3
projecthttps://github.com/robinpellegrims/pellegrims/blob/master/libs/nx-remotecache-s3/src/lib/setup-s3-task-runner.ts#L44-L45