Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: parse Service options from 'npv.service.options' #1

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

william-p
Copy link
Contributor

Hi,
with this proto:

service Echo {
    option (meta).description = "Echo webservice";
    option (meta).basePath = "/echo";

    rpc ....
}

Service options was not parsed correctly because options are stored in npv.service.options. (i don't know why)

This PR parse npv.service.options if defined.

Thanks

@bojand
Copy link
Owner

bojand commented Mar 17, 2017

Hello,

Thanks for the PR. Can you add a test please. Either add a couple of options to the existing proto and modify the expected one; or add a simple sample proto file with option and add a test for it similar to the existing ones.

Thanks.

@william-p
Copy link
Contributor Author

william-p commented Mar 17, 2017

Sorry for missing tests, should be ok :)

Documentation for Custom Options.

@bojand bojand merged commit 8d38a4b into bojand:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants