Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build job failing due to version mismatch #13825

Closed
bryevdv opened this issue Apr 12, 2024 · 3 comments
Closed

Build job failing due to version mismatch #13825

bryevdv opened this issue Apr 12, 2024 · 3 comments

Comments

@bryevdv
Copy link
Member

bryevdv commented Apr 12, 2024

Now seeing this on all jobs:

Version mismatch: given version (3.5.dev1+36.gc297d210) != package version (3.5.0.dev1+36.gc297d210)

In the last successful build the dist filename had the .0

++++ ls dist/bokeh-3.5.0.dev1+27.g0aeab18d.tar.gz
+++ basename dist/bokeh-3.5.0.dev1+27.g0aeab18d.tar.gz .tar.gz
++ echo bokeh-3.5.0.dev1+27.g0aeab18d
+ export VERSION=3.5.0.dev1+27.g0aeab18d
+ VERSION=3.5.0.dev1+27.g0aeab18d

But in the lastest failing ones that is not the case

++++ ls dist/bokeh-3.5.dev1+36.gc297d210.tar.gz
+++ basename dist/bokeh-3.5.dev1+36.gc297d210.tar.gz .tar.gz
++ echo bokeh-3.5.dev1+36.gc297d210
+ export VERSION=3.5.dev1+36.gc297d210
+ VERSION=3.5.dev1+36.gc297d210

Best guess is the new setuptools release from 4 hours ago has decided to drop .0 point versions when build is run. Unfortunately the build job does not dump its package list so it's impossible to compare to successful jobs (we should fix that too).

Assuming we determine the problem is in fact new setuptools, we have a few options:

  • pin setuptools version 👎
  • change the strict string comparison in bokeh.util.package to a proper version compare
  • check with upstream to see if there is a way to restore the old behavior (or see if it is a bug)
@bryevdv
Copy link
Member Author

bryevdv commented Apr 12, 2024

And in fact today's setuptools releases have been yanked:

Screenshot 2024-04-12 at 16 37 21

@bryevdv
Copy link
Member Author

bryevdv commented Apr 12, 2024

ref: pypa/setuptools#4302

@bryevdv bryevdv removed this from the 3.5 milestone Apr 16, 2024
@bryevdv
Copy link
Member Author

bryevdv commented Apr 16, 2024

This was resolved upstream

@bryevdv bryevdv closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant