Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TravisCI failing every py27 examples test #3636

Closed
bryevdv opened this issue Jan 12, 2016 · 2 comments · Fixed by #3643
Closed

TravisCI failing every py27 examples test #3636

bryevdv opened this issue Jan 12, 2016 · 2 comments · Fixed by #3643

Comments

@bryevdv
Copy link
Member

bryevdv commented Jan 12, 2016

ping @mattpap

I can't tell if it is examples/glyphs.py or examples/glyph.ipynb that is the problem. It ostensibly finishes the notebook, and crashes a few tests later while or after writing output for glyphs.py, but then it spits out a bunch of log/debugging that seems to be from the glyph.ipynb notebook. It is currently impossible to merge any PRs with clean tests now this happens every test run.

Ref: https://travis-ci.org/bokeh/bokeh/jobs/101701413#L1469

@canavandl
Copy link
Contributor

The issue appears related to a regression in phantomjs@1.9.8. See issues:

https://github.com/n1k0/casperjs/issues/1068
ariya/phantomjs#12697

In our test system we launch phantomjs (with glyph.py as a arg) as a subprocess and listen to stdout for a potential response.status='fail'. The regression in phantomjs causes a warn to be captured several times:

Unsafe JavaScript attempt to access frame with URL about:blank from frame
with URL file:///Users/lcanavan/dev/bokeh/examples/glyphs.html.
Domains, protocols and ports must match.

Then we try to pass this list of responses to python's json.decode which raises an exception.

The phantomjs folks didn't seem to get it fixed until the 2.0.0 release. The most recent phantomjs version in the npm package in our bokeh channel appears to only have 1.9.8, so we're running a buggy version.

There seem to be three solutions (I tested no. 1 and no. 3 locally):

  1. Downgrade to phantomjs@1.9.7-15
  2. Update npm and upgrade to phantomjs@2.0.0 (sort of assuming it's stable)
  3. Add a '--web-security=false' flag to the phantomjs cmd (which silences these warns)

I vote for no. 1 (seems easiest)

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants