-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs example in first_steps_8.rst #13161
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-3.2 #13161 +/- ##
==============================================
- Coverage 92.42% 92.41% -0.01%
==============================================
Files 316 315 -1
Lines 20040 20038 -2
==============================================
- Hits 18521 18518 -3
- Misses 1519 1520 +1 |
cc @tcmetzger IIRC omitting the |
I honestly don't remember why there is no If we do add
|
@tcmetzger - I applied your suggestion in 4546f65 |
True. The key question isn't explained: "Why does ColumnDataSource and the other classes exist? Even if they exist internally, why should I as user care or use them?"
I think simply having full working examples that newbies can copy & paste is the biggest advantage. This actually happened to me: I copy & pasted the example and didn't get a plot. Took me a minute to figure out that I was simply missing the "show" call, but the example otherwise was working perfectly. I do think it would be good to have some information on "why" ColumnDataSource and the filters exist, and "when" I have to or should use them over simple pandas DataFrames, and also what the performance implications are when bokeh makes copies. But that's a different possible aspect of the docs that could be improved. At least I don't know the answer and can't add it here (if you agree something could be added). |
Thanks for the PR @cdeil ! |
* Improve docs example in first_steps_8.rst * Update figure in docs example first_steps_8.rst
* Improve performance of WebGL line glyph (#13236) * Improve performance of webgl line glyph * Update baseline images * Update ruff repo links (#13242) * Fix `PropertyValueColumnData._stream()` to handle `rollover=0` (#13239) * Fix `PropertyValueColumnData._stream()` to handle `rollover=0` * Check 'event.data' in the unit tests * Improve docs example in first_steps_8.rst (#13161) * Improve docs example in first_steps_8.rst * Update figure in docs example first_steps_8.rst * Resolve issues with high DPI GridPlot exports (#13253) * Allow to disable DatePicker (etc.) after creation (#13256) * Use ../core/kinds instead of core/kinds in imports (#13254) * Don't paint undisplayed plots (#13250) * Update theme.py (#13270) * Fixed Broken Link (#13266) * Fixed Broken Link * Update docs/bokeh/source/docs/first_steps/first_steps_9.rst Co-authored-by: Bryan Van de Ven <bryan@bokeh.org> --------- Co-authored-by: Bryan Van de Ven <bryan@bokeh.org> * fix unterminated string literals in example code [skip ci] (#13274) * Fix Legend's grid layout for uneven number of items (#13263) * 13272 update legend docs (#13273) * update docs for two dimensional legends * Apply suggestions from code review * Implement cloneable interface in ndarrays (#13232) * Update docs/bokeh/switcher.json * Added release notes --------- Co-authored-by: Ian Thomas <ianthomas23@gmail.com> Co-authored-by: Xiaoyang Liu <siujoeng.lau@gmail.com> Co-authored-by: Christoph Deil <Deil.Christoph@gmail.com> Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Rajat Shenoi <rajatshenoi@outlook.com> Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
This is a tiny improvement to a docs example, adding a show() call to have a full working example and be consistent with the other examples in the getting started guide.
Filing a [BUG] for such small docs improvements that aren't really bugs seems overkill. Hope it's OK as an exception.