Use ../core/kinds instead of core/kinds in imports
#13254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-3.3 #13254 +/- ##
===========================================
Coverage 92.44% 92.44%
===========================================
Files 315 315
Lines 20107 20107
===========================================
Hits 18587 18587
Misses 1520 1520 |
bryevdv
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
There are still imports from e.g. core/enums just above. It's not at all clear when this treatment is necessary and when it is not, so some detailed guidance would be extremely appreciated.
Can/should we just update all internal imports to this style? It seem much uglier, but consistency and removing decision making would be preferable IMO.
|
It's only |
mattpap
added a commit
that referenced
this pull request
Jul 18, 2023
mattpap
added a commit
that referenced
this pull request
Jul 19, 2023
mattpap
added a commit
that referenced
this pull request
Jul 20, 2023
* Improve performance of WebGL line glyph (#13236) * Improve performance of webgl line glyph * Update baseline images * Update ruff repo links (#13242) * Fix `PropertyValueColumnData._stream()` to handle `rollover=0` (#13239) * Fix `PropertyValueColumnData._stream()` to handle `rollover=0` * Check 'event.data' in the unit tests * Improve docs example in first_steps_8.rst (#13161) * Improve docs example in first_steps_8.rst * Update figure in docs example first_steps_8.rst * Resolve issues with high DPI GridPlot exports (#13253) * Allow to disable DatePicker (etc.) after creation (#13256) * Use ../core/kinds instead of core/kinds in imports (#13254) * Don't paint undisplayed plots (#13250) * Update theme.py (#13270) * Fixed Broken Link (#13266) * Fixed Broken Link * Update docs/bokeh/source/docs/first_steps/first_steps_9.rst Co-authored-by: Bryan Van de Ven <bryan@bokeh.org> --------- Co-authored-by: Bryan Van de Ven <bryan@bokeh.org> * fix unterminated string literals in example code [skip ci] (#13274) * Fix Legend's grid layout for uneven number of items (#13263) * 13272 update legend docs (#13273) * update docs for two dimensional legends * Apply suggestions from code review * Implement cloneable interface in ndarrays (#13232) * Update docs/bokeh/switcher.json * Added release notes --------- Co-authored-by: Ian Thomas <ianthomas23@gmail.com> Co-authored-by: Xiaoyang Liu <siujoeng.lau@gmail.com> Co-authored-by: Christoph Deil <Deil.Christoph@gmail.com> Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Rajat Shenoi <rajatshenoi@outlook.com> Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required due to TypeScript's handling of injected imports in generated type declarations, which cannot be processed by our source transforms, so we have to do that "transform" manually.