Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 3.2.1 #13271

Merged
merged 16 commits into from
Jul 20, 2023
Merged

Backports for 3.2.1 #13271

merged 16 commits into from
Jul 20, 2023

Conversation

ianthomas23 and others added 4 commits July 18, 2023 16:56
* Improve performance of webgl line glyph

* Update baseline images
* Fix `PropertyValueColumnData._stream()` to handle `rollover=0`

* Check 'event.data' in the unit tests
* Improve docs example in first_steps_8.rst

* Update figure in docs example first_steps_8.rst
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #13271 (4891b86) into branch-3.2 (582a182) will increase coverage by 0.45%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           branch-3.2   #13271      +/-   ##
==============================================
+ Coverage       91.99%   92.44%   +0.45%     
==============================================
  Files             315      315              
  Lines           20090    20090              
==============================================
+ Hits            18481    18572      +91     
+ Misses           1609     1518      -91     

@bryevdv
Copy link
Member

bryevdv commented Jul 18, 2023

FY #13242 is listed twice (looks like a pure duplicate rather than an accidental replacement of something else, based on the commits)

@mattpap
Copy link
Contributor Author

mattpap commented Jul 18, 2023

It was a duplicate, due to me fighting with github's primitive UI.

@mattpap
Copy link
Contributor Author

mattpap commented Jul 19, 2023

@bokeh/dev, this is ready. When approved, I will start 3.2.1 release build.

@ianthomas23
Copy link
Member

It looks like this includes some of the regression tests added in #13195 but we don't have the new functionality of that PR so the tests fail. That PR is probably too significant to add in here, so maybe we should just remove the regression tests?

@bryevdv
Copy link
Member

bryevdv commented Jul 19, 2023

When approved, I will start 3.2.1 release build.

You'll want update switcher.json with the new version first

@mattpap mattpap force-pushed the mattpap/backports_for_3.2.1 branch from c22ff73 to 648cf66 Compare July 19, 2023 18:29
@mattpap
Copy link
Contributor Author

mattpap commented Jul 19, 2023

You'll want update switcher.json with the new version first

OK. Shouldn't this be done automatically by the release build? Actually, I don't see it being updated in the preview backports PR (#13103).

@mattpap
Copy link
Contributor Author

mattpap commented Jul 19, 2023

(...), so maybe we should just remove the regression tests?

Yes. That was a bad cherry-pick with conflicts.

@mattpap
Copy link
Contributor Author

mattpap commented Jul 19, 2023

I see switcher.json was updated in a follow-up commit in 3.1.1. This also reminds me about release notes.

@bryevdv
Copy link
Member

bryevdv commented Jul 19, 2023

Shouldn't this be done automatically by the release build?

It would be nice for this to be done automatically, yes.

I don't see it being updated in the preview backports PR

Sometimes it happens in a separate docs/release notes PR

@mattpap mattpap merged commit 2664c2e into branch-3.2 Jul 20, 2023
27 checks passed
@mattpap mattpap deleted the mattpap/backports_for_3.2.1 branch July 20, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants