ENH: adds --p-n-threads option to trim-alignment
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbokulich
requested changes
Feb 7, 2024
There was a problem hiding this comment.
thanks @mikerobeson ! Small comment inline. Have you tested the performance speed-up with multi-threading? I can take a look, but curious how much of a bump we see.
| """ | ||
| Trim alignment based on primer alignment or explicitly specified | ||
| positions. When at least one primer sequence is given, primer-based | ||
| trimming will be performed, otherwise position-based trimming is done. | ||
| trimming will be performed via the `addfragments` option of mafft, | ||
| otherwise position-based trimming is done. |
There was a problem hiding this comment.
the n_threads param would not be effective as far as I can tell when position-based trimming is done, so this should be mentioned in the param description
There was a problem hiding this comment.
RE param description: Oooh, good catch! Will fix!
RE multi threading: Yes this does scale well. The table below is based on ~5k sequences randomly subsampled from SILVA's 50k position FASTA alignment file, on my M1 Max laptop. Mirroring @colinbrislawn's results.
| threads | time |
|---|---|
| 8 | 6m 40.278s |
| 4 | 9m 20.686s |
| 2 | 14m 36.920s |
| 1 | 25m 13.873s |
Example command:
qiime rescript trim-alignment \
--i-aligned-sequences silva-138-1-nr99-aln-dna-ss01.qza \
--p-primer-fwd GTGYCAGCMGCCGCGGTAA \
--p-primer-rev CCGYCAATTYMTTTRAGTTT \
--p-n-threads 8 \
--o-trimmed-sequences silva-138-1-nr99-aln-dna-ss01-v4v5-trimmed.qza \
--verbose
|
Hey @mikerobeson , LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
Also, made some minor help text and documentation edits.