Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status transition changes removing taxonomy #3868

Closed
GwendolenLynch opened this issue Jul 25, 2015 · 13 comments
Closed

Status transition changes removing taxonomy #3868

GwendolenLynch opened this issue Jul 25, 2015 · 13 comments
Assignees
Labels
blocking release bug A bug that has been verified regression

Comments

@GwendolenLynch
Copy link
Contributor

To reproduce:

  • Listing page for 'Pages'
  • 'Actions' drop down select a different status
@GwendolenLynch GwendolenLynch added bug A bug that has been verified regression labels Jul 25, 2015
@GwendolenLynch GwendolenLynch added this to the Bolt 2.3 - Feature release milestone Jul 25, 2015
@GwendolenLynch
Copy link
Contributor Author

Related to #3908 and release/2.2 PR #3910

@simnom
Copy link

simnom commented Sep 30, 2015

Is there a fix for this in the interim before 2.3? It's causing me a bit of grief :-\ Still seems to be stripping taxonomies set with v2.2.11. Thanks!

@GwendolenLynch
Copy link
Contributor Author

@simnom this should have been fixed in 2.2.8+ with #3910

@SvanteRichter
Copy link
Contributor

Closing this as it should be fixed in #3910.

@simnom If you are still seeing this in current versions of bolt please reopen :)

@simnom
Copy link

simnom commented Oct 2, 2015

Hey, will do. Seeing some strange things when contenttypes have multiple taxonomies. Trying to work out what's going on and will post back here or create a PR.

@simnom
Copy link

simnom commented Oct 2, 2015

Hey @SahAssar, just been looking through this in more detail. I think that there's an issue if the contenttype has multiple taxonomies specifically in the getIndexedTaxonomy function, I would suggest that:

$ret[] = $content->group['slug'] . '#' . $content->group['order'];

Will always return the first content taxonomy which then overwrites any subsequent taxonomy values that are set.

Looking to see if I can fix but this is my first look through the heavy lifting in Bolt so any suggestions would be welcome.

@SvanteRichter
Copy link
Contributor

Alright, reopening, Perhaps @GawainLynch or @rossriley could shed som light on this?

@SvanteRichter SvanteRichter reopened this Oct 2, 2015
@simnom
Copy link

simnom commented Oct 2, 2015

Digging a bit deeper.....

I'm using multiple taxonomies on a contenttype and, rightly or wrongly, one of the defined taxonomies defines grouping. At this point it always uses the initially set group. Passing the taxonomytype through to getIndexedTaxonomy and checking for grouping seems to fix. I'll create a PR for review with #4188.

@GwendolenLynch
Copy link
Contributor Author

OK, the reason that this is open still is that we were able to address this problem in 2.2, but master was waiting on #4189 to be finished… submitted… and merged… due in about 5 minutes from now 😁

@simnom
Copy link

simnom commented Oct 2, 2015

5 minutes in a galaxy far far away? ;-)

@GwendolenLynch
Copy link
Contributor Author

Hehe… that's the one

bobdenotter added a commit that referenced this issue Oct 3, 2015
…when-grouped

Fixes #3868 - Taxonomies being wiped on status change using grouped taxonomy
@SvanteRichter
Copy link
Contributor

Fixed by #4188

@GwendolenLynch
Copy link
Contributor Author

Still a problem in master… was planning on getting to this today…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking release bug A bug that has been verified regression
Projects
None yet
Development

No branches or pull requests

4 participants