Fix bug in repeater buttons #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Currently, when reaching the `limit` in a repeater definition, the [Add new Repeater set] button gets grayed out but clicking it still adds a new repeater set, and the [Duplicate set] button also gets wrongly grayed out. Fix: The `.disabled` class was being applied to the [Duplicate set] button, instead of adding the “disabled” property to the [Add new Repeater set] button.
rossriley
suggested changes
Apr 1, 2017
| @@ -246,10 +246,10 @@ | |||
|
|
|||
| if (this._count >= this.options.maximum) { | |||
| this._ui.add.addClass('disabled'); | |||
| this.element.find('.duplicate-button').addClass('disabled'); | |||
| this._ui.add.prop('disabled', 'disabled'); | |||
There was a problem hiding this comment.
Can you also add this line underneath:
this.element.find('.duplicate-button').prop('disabled', 'disabled');
| } else { | ||
| this._ui.add.removeClass('disabled'); | ||
| this.element.find('.duplicate-button').removeClass('disabled'); | ||
| this._ui.add.prop('disabled', false); |
There was a problem hiding this comment.
and this line underneath here:
this.element.find('.duplicate-button').prop('disabled', false);
|
@ross I should have known that, thanks for catching it! |
I think you want @rossriley |
|
@ross you're right, sorry, I am used to his Slack handle :-) |
- make sure ‘duplicate set’ button is disabled when max repeaters are reached - make sure ‘delete set’ button is disabled when minimum is reached
|
I updated the files. Just pinging you since I am not sure you got a notification from git, I didn't. |
|
@rossriley This should be GTG now, right? |
rossriley
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, when reaching the
limitset in a repeater definition, the [Add new Repeater set] button gets grayed out but clicking it still adds a new repeater set, and the [Duplicate set] button gets wrongly grayed out.Fix:
The
.disabledclass was being applied to the [Duplicate set] buttons, instead of adding the“disabled”property to the [Add new Repeater set] button.