Redirects hiding flash messages

[xiaohutai]

I have troubles showing (custom) flash messages (from the session.flashbag).

So in order to fix the flooding of the system log, there were some return responses introduced:

• e254959
• 131976a

Removing the return from return $response->send(); in src/Submission/Handler/Redirect.php makes the messages appear, and everything seems to be working fine again:

• https://github.com/bolt/boltforms/blob/4.2/src/Submission/Handler/Redirect.php#L62
• https://github.com/bolt/boltforms/blob/4.2/src/Submission/Handler/Redirect.php#L76

However, this will start flooding the system log again (which is preferable to no messages shown at all).

Removing the Exception simply breaks the form. Only with an Exception or exit/die, does it do what I want. But relying on this as a control structure seems like a super bad idea.

See https://github.com/bolt/boltforms/blob/4.2/src/Submission/Processor/Redirect.php#L90-L95

But I also have a feeling that something else might break because of these fixes. So, I'm not sure how to go from here.

[bobdenotter]

See also #257

[xiaohutai]

Fixed in 4.3.0-beta.1, but the caveats still apply.