Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue [#514](https://github.com/bolt/core/issues/514) #633

Conversation

fatguytyson
Copy link
Contributor

Changed the repository method to accept the credential(string) and has
the storage engine compare the lowercase values. At least this is
consistent to the strings compared so it should be a consistent
experience

Changed the repository method to accept the credential(string) and has
the storage engine compare the lowercase values. At least this is
consistent to the strings compared so it should be a consistent
experience
@bobdenotter
Copy link
Member

bobdenotter commented Sep 18, 2019

Hi @fatguytyson ,

Thanks! Looks like this one partially fixes #514, right?

Could it be adapted to accept email as well, so we can fix that in one go?

That's what I get for replying before having my coffee. Or at least reading properly! Looks great!

Fixes #514

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants