Rewrite #21
Merged
Rewrite #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 :-) |
added 5 commits
September 9, 2015 21:56
- require - removed http-foundation. added bolt/filesystem, doctrine/cache, and PHP 5.4. - require-dev - removed bolt/bolt. added phpunit and silex. - Set minimum stability from dev to stable. - Moved autoloading tests to dev autoloader.
…converting errors/notices/warnings to exceptions.
…zy boundaries when checking for color.
| class Creator implements CreatorInterface | ||
| { | ||
| /** @var bool */ | ||
| protected $allowUpscale; |
There was a problem hiding this comment.
Change to limitUpscaling
|
👍 |
added 19 commits
September 10, 2015 02:40
…Response to function more like BinaryFileResponse. Updated Controller to work without base controller from core.
…les into nullable $webFs. Made $cache nullable.
…n Controller now and passing it to Responder.
…path in getHash if src image is null
added 7 commits
September 10, 2015 02:40
|
Thumbs up from @bobdenotter, @rossriley & the 🐨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok
when ready. Don't tag a release yet though.