Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pagination not working #34

Closed
melcarthus opened this issue Jun 21, 2018 · 5 comments · Fixed by #50
Closed

[BUG] Pagination not working #34

melcarthus opened this issue Jun 21, 2018 · 5 comments · Fixed by #50

Comments

@melcarthus
Copy link


The 11th entry does not show. Page does not load pagination and only the first 10 accounts are visible.

Details

  • Relevant Bolt Auth Version: [ 3.0.5 | master ]
  • Relevant Bolt Version: [ 3.5.3 ]
  • PHP version: [ 7.0 ]
  • For UX/UI issues: [ Chrome Version 67.0.3396.87 (Official Build) (64-bit) ]

Happens on /bolt/extensions/auth
Add 11 accounts, you will see that there are only 10 visible.
Change 10 to 20 for example here: https://github.com/BoltAuth/Auth/blob/f1080cec5e805b907be9c84d2943d5d2de1ed7a8/src/Controller/Backend.php#L177-L179
and you will see the accounts are still there, just no pagination.

If you're filing a bug, please describe how to reproduce it. Include as much
relevant information as possible, such as:

other plugins that are installed
Seo 1.10
BoltForms 4.2.3
EmailSpooler 3.1.1
Sitemap 2.5.0
google/recaptcha 1.1.3
pagerfanta/pagerfanta 1.1.0
Paragonie/random_compat 2.0.15
ramsey/uuid 3.7.3

@SvanteRichter
Copy link
Collaborator

It seems like the pager isn't setting the page query param correctly. I try to see if I get time to fix or if anyone else has a PR I'd be glad to merge.

@ncareau
Copy link

ncareau commented Apr 17, 2019

@SahAssar Fix is done, can you merge ? Thank you.

@zeamedia
Copy link

Hey all. Is there any update on this issue?

@melcarthus
Copy link
Author

Yes a year ago there was a fix. Was it never merged into production?

@zeamedia
Copy link

Yes, I've just seen the fix in the linked issue - works for me as well.
I am wondering why this fix never has been merged into production.

{% include '@bolt/components/pager.twig' with { 'pager': pager.pager, 'surround' : pager.surr } only %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants