This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@snormore There's a bunch of changes in this PR but the biggest thing is that it'll actually create a bucket and read it back out in a separate transaction! Woohoo! Small victories. :)
I also simplified the bucket meta storage (called
sys
in the code). It was a real bucket that required a cursor to traverse but that was a pain in the ass. Most of the time there will be a relateivly small number of buckets so we don't need to optimize for a huge number by using a B+tree. There's now a page type calledp_sys
that just stores a list of buckets. Easy peasy. It's not very optimized right now but we can improve that later.Next up is reading and writing data in a bucket. It's partially there but I need to test it and clean it up. Also, there's no support for spilling buckets to pages. I can explain everything in more detail tomorrow.