fix(@clack/prompts): add spinner hook to handle process exit
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: improve group `types` for readability (bombshell-dev#105)
🦋 Changeset detectedLatest commit: 4a5a00f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mist3rBru
changed the title
spinner hook to handle process exitspinner hook to handle process exit
|
Code with |
cpreston321
changed the title
spinner hook to handle process exitspinner hook to handle process exit
cpreston321
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
@Mist3rBru The changes look good!
Thanks for fixing the conflicts!
|
Hey @Mist3rBru While testing I did see this: 
If you want to test yourself: The code looks good but it seems that maybe something messed up when merge. I just did a Thanks, |
cpreston321
requested changes
Aug 9, 2023
cpreston321
reviewed
Aug 9, 2023
fix output message
cpreston321
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
It adds a hook to
spinner, that prints a default message and avoid terminal conflicts, it triggers on: