Support to force/forbid ending newlines in case block #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 140
💛 - Coveralls |
akarl
approved these changes
Nov 4, 2019
bombsimon
force-pushed
the
case-trailing-newline
branch
from
002cfa7
to
6f8a929
Compare
This commit loosens up quite alot on how case blocks should look. The main reason is because they're quite complex, especially if you consider comments. A comment in the end of a case might (depending on ths Pos()) belong to the next case for example. Even gofmt handles indentation for comments in case blocks in multiple ways. From now on the end user may or may not end cases with newlines or comments. With this commit a user can configure when you *must* end with a whitespace to improve readability which essentially is what this litner is about
bombsimon
force-pushed
the
case-trailing-newline
branch
from
6f8a929
to
5adde1b
Compare
|
Ok so now I've written my thoughts in #49 and in the commit but might as well add a short description here as well.
Resolves #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #49.
This is (maybe) a WIP/POC. I spent a lot of time on this since I couldn't get the logic to be easy enough to make this obvious. And just when I thought that I had something going on I realised that I should probably split this up in two settings.
I'm not sure how to combine these but I'll use this PR to iterate proposals.