Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thickness produces extra rows in the result table #132

Closed
mdoube opened this issue Sep 4, 2018 · 3 comments
Closed

Thickness produces extra rows in the result table #132

mdoube opened this issue Sep 4, 2018 · 3 comments
Assignees

Comments

@mdoube
Copy link
Member

mdoube commented Sep 4, 2018

Describe the bug
When Thickness completes, it adds two new rows to the result table:
ImageTitle_Tb.Th
Image Title_Tb.Sp

To Reproduce
Steps to reproduce the behavior:

  1. Open an image
  2. Run Plugins > BoneJ > Thickness

Expected behavior
Results should be entered in the row with label according to the original input image

Screenshots
screenshot from 2018-09-04 09-31-51

Environment

  • OS: Ubuntu 16.04
  • Java version: 1.8.0_172 (Oracle)
  • Fiji updated today
  • BoneJ2 5e3be0c
@mdoube mdoube self-assigned this Sep 4, 2018
@rimadoma
Copy link
Contributor

rimadoma commented Sep 4, 2018

My reasoning was that since the thickness map images have different titles than the original, it would make sense for them to have separate rows. I can appreciate why you'd prefer the results on one row.

@mdoube
Copy link
Member Author

mdoube commented Sep 4, 2018 via email

@rimadoma
Copy link
Contributor

rimadoma commented Sep 4, 2018

Yes, you just need to change the labels inserted to the table in ThicknessWrapper (also the tests of the plug-in will need an update). I see you assigned the issue to yourself @mdoube, would you like to create the PR, when you have the time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants