Update chai-as-promised to version 6.0.0 🚀 #74
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
chai-as-promised just published its new version 6.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of chai-as-promised.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
In #167, @lddubeau made many improvements to edge cases that have plagued users:
rejectedWith
to behave more like Chai'sthrows
asserter..fulfilled
,.rejected
, and.rejectedWith
to change the asserter target to the fulfillment value or rejection reason, so that further assertions with.and
act on them..fulfilled
, when successful, to return a promise that fulfills with the fulfillment value.rejected
and.rejectedWith
, when successful, to return a promise that fulfills with the rejection reasonAlso, Chai as Promised now only supplies a CommonJS-style module. To get AMD or
<script>
-compatibility, use a bundler tool like browserify.The new version differs by 28 commits .
b2cfbdc
6.0.0
479f867
Update copyright year
bb51e07
Switch to pure CommonJS
fc9f868
Load check-error in the browser too
33ce9df
Bring promise rejection tests in line with Chai.
10beb9e
Harmonize error messages with those of Chai
a8b88d0
Fix the .not.rejectedWith tests
1f7fc93
Use check-error to get expected constructor name
e425136
Redesign UMD code to allow imports
823c15b
Allow chaining tests and promises.
52beb1f
Add a notMessage option
40fe94e
Restructure to avoid so much nesting
62e137f
Add test cases that reproduce issue #113
7662aca
Add a case that replicates issue #64
deb505c
Add test cases to cover issue #47
There are 28 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade