Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Wine #68

Merged
merged 2 commits into from
Aug 1, 2021
Merged

Support for Wine #68

merged 2 commits into from
Aug 1, 2021

Conversation

PeakKS
Copy link
Contributor

@PeakKS PeakKS commented Jul 19, 2021

I saw the other wine PR #66 and it is indeed broken. I based this version off of that one but actually made it work. This needs to be tested to make sure it doesn't affect windows functionality.

@McGravel
Copy link
Collaborator

Quickly gave this a test.
The "Wine" option doesn't appear anywhere on my Windows machine, so that appears to be working!
I did a very simple export of a model without issues.

@bonjorno7 bonjorno7 mentioned this pull request Jul 21, 2021
Closed
Copy link
Owner

@bonjorno7 bonjorno7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, but I would've liked to see you use pathlib instead of os.path.
I'm going to merge it into a branch, and do that there, to save you the trouble.

addon/types/model_export/model.py Show resolved Hide resolved
addon/types/model_export/model.py Show resolved Hide resolved
@bonjorno7 bonjorno7 changed the base branch from main to wine August 1, 2021 20:53
@bonjorno7 bonjorno7 merged commit 7a47364 into bonjorno7:wine Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants