Fix author_trigger() recalculating search_vector of the wrong books #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minnozz
changed the title
The join that was used to match books to a changed author used the id column instead of the author_id column to join on authors. This migration re-calculates all book search vectors to fix any missed author name changes.
Minnozz
force-pushed
the
fix-author-trigger
branch
from
0895f49
to
adaf7a3
Compare
|
Great catch! There's a pending PR by me that introduces trigger migrations for easier maintenance (#3134), and fixes this bug too, I believe (if it does, it would be in Since you already looked at trigger code… I'd be most grateful if at some point you can read, or review, that PR. The more eyes on such a tricky change, the better! |
|
@dato I'll take a look at your PR later this week! (Though I can't officially review PRs (yet)) |
7 tasks
|
Closed in favor of #3134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The join that was used to match books to a changed author used the id column instead of the author_id column to join on authors.
This migration re-calculates all book search vectors to fix any missed author name changes.