Docker: make bind mounts of source code read only #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except dev-tools, since it needs to be able to change the source.
… only Otherwise the static_volume and media_volume can't be mounted there.
|
I learned something new about docker! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The services don't need write access to the application source, except for the
dev-toolscontainer.Make sure the
staticandimagesmount points exist as "empty" directories, since Docker can't create them any more in the read only volume. This should not cause problems for non-Docker setups, since only a.gitkeepfile is added.When running
./bw-dev up, no longer start thedev-toolscontainer. It is only used withdocker compose run, which spins up a new container anyway.