-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test suite to repo #11
Conversation
f389475
to
7a3a153
Compare
Very nice! Can we add a github action to this so it runs on PRs? Something like this: https://github.com/boolean-uk/js-fundamentals-functions-1/blob/main/.github/workflows/standard-criteria-tests.yml |
@vherus -- I knew I forgot to do something, but couldn't remember what! 🙈 Good shout! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff.
Can you standardise the CI test scripts and actions?
Follow the format below:
- all exercises should have at least the defiend standard criteria testable with a workflow and corresponding test suite.
- If there are defined extension criteria, there should be a separate workflow with a corresponding test suite.
Example: https://github.com/boolean-uk/api-express-database/tree/main/.github/workflows
If you want to define extra test scripts - feel free to do so, beyond the above standardised ones.
@dearshrewdwit -- thanks for the review. I've addressed your comment (I believe). There are no extensions, just the standard, so I've updated the workflow filename & action name, and also updated the npm script name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Let's get it merged
Objective
Add tests so that we can check students' work using automated tests (via GH Actions).
What Has Changed?
dmff
object to retrieve the locally generated modelsHow To Test
npm ci
prisma.schema
file to contain the correct modelsnpm run test:<number>
where<number>
is replaced by the relevant digit (e.g. to test Requirement 2, runnpm run test:2
).npm run test:all
.