Adding README with some additional hints for building on Windows 64bit #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for this. |
boombuler
added a commit
that referenced
this pull request
Mar 21, 2015
Adding README with some additional hints for building on Windows 64bit
crewjam
pushed a commit
to crewjam/hid
that referenced
this pull request
Feb 12, 2018
* Compiles under osx with golang 1.9 * Code cleanup per PR review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while building this HID package on Windows 8.1 64bit, I've discovered one issue and solved it.
I wanted to share my solution with others and thus added a README.md file to this project sources.
For details about the issue, please have a look at my commits.
Because this library is intended to be used by developers, I think adding such information
in the README file is the best place to be. Comparing to add a 'Github issue',
the README file is closer to the actual code. Thus I prefer adding such hints/pro tips for building
in the README file.
Feel free to simply merge the PR or adopt it.
Best regards
Martin