-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hostAlias section to data loader #59
Conversation
This is probably a Flow 3.8.0 change as it's not been verified in all the Flow 3.7.0 changes so far. |
Change is very minor, i.e. it includes an optional hostAlias block to the loader pod descriptor. |
My preference is that it waits until 3.8.0 as 3.7.0 has been in draft release for 2 weeks awaiting on one front end tag. However, we now have multiple chart and worker tags that are trying to be added with creep in the release scope. However, if it was agreed in the community meeting, then we can add but we would need the documentation updated ASAP and README updated. |
Also has it been tested
The TLS change required two last-minute emergency fixes in release shakeout so im trying to make sure that we don't ship with a faulty install. |
There's no documentation currently for hostAliases in the README.md |
Wrt testing, yes to all for similar chart, no to Flow as it hasn't been merged and packaged as yet |
Updated chart pushed |
Thx @morarucostel @tlawrie for the reviews. Please let me know when we can merge this PR. Thx. |
@gchickma With the two approvals, lets merge this in? |
Add hostAlias section to data loader