🐛 [ut] Source-file-location fails on macOS, giving unknown, Fix…
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - On macOS, with both g++9 homebrew and clang-9 MacPorts the UT tests all fail with `unknown`. Solution: - Fix detection of `source location` builtins. Use `__has_builtin` for clang based compilers. Enable it by default for GCC >= 9 (GCC HEAD has support for it). Disable it for MSVC which doesn't support these builtins yet.
kris-jusiak
force-pushed
the
builtins_detection
branch
from
0dcb157
to
f67f9d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #291
Problem:
unknown.Solution:
source locationbuiltins.Use
__has_builtinfor clang based compilers.Enable it by default for GCC >= 9 (GCC HEAD has support for it).
Disable it for MSVC which doesn't support these builtins yet.