New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid exporting compile options #495

Closed

ken-matsui wants to merge 2 commits into boost-ext:master from ken-matsui:avoid-exporting-compile-options

ken-matsui commented Mar 10, 2022 •

edited

Loading

Problem:

The ut (aliased as Boost::ut) target exports compile options as INTERFACE, but it mostly does not need. (this is also pointed out as FIXME)
However, it seems that tests, examples, and benchmarks want to use the options.

Solution:

Delete compile options for the interface ut.
Add compile options for targets of tests, examples, and benchmarks as PRIVATE.

Issue: #

Reviewers:
@


          Avoid exporting compile options

4cf2a1e

Author

ken-matsui commented May 29, 2022

Hi @krzysztof-jusiak,
Could you please review my PR at your convenience?

ClausKlein mentioned this pull request

Do not export pedantic compiler warning settings #519

Merged


          Merge branch 'master' into avoid-exporting-compile-options

ba324b9

ken-matsui closed this

ken-matsui deleted the avoid-exporting-compile-options branch

January 30, 2023 02:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet